Hacker Newsnew | past | comments | ask | show | jobs | submitlogin
Google Domains DDNS Updater: Python (github.com/jasonslay)
1 point by jasonslay on Oct 5, 2015 | hide | past | favorite | 2 comments


Not to be that guy - but did you test this?

    parameters = {'hostname': self.hostname, 'myip': myip}
Change to:

    parameters = {'hostname': self.hostname, 'myip': ip}
Change:

    for host in hosts:
        print(host)
To:

    for host in hosts:
        host.update(myip)
        print(host)


Good catch on the myip vs ip syntax error. It worked because of the myip global. The later change isn't required because the constructor calls the update. I may go ahead and adopt your update suggestion to make it clearer what is actually going on. Thanks!




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: