That loan was made because the US has significant interests in catalyzing the growth of electric transport, for many reasons. It was not designed to make the country money directly. Tesla is far from alone in receiving such loans from the government. Oil companies receive far more money as direct tax breaks (i.e. never paid back).